Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(image): updates colored image of ddd modeling process with arrows #33

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

javujavichi
Copy link
Collaborator

@javujavichi javujavichi commented Jun 28, 2022

Sumary
This PR updates the domain-driven design starter process diagram with a colored one, with grey arrows. I'm opening this PR because I talked to @Max-Git and he liked the colored version and asked me to submit a PR

Where the change occurs
README.md file

Does it have test?
N/A

@fabridinapoli
Copy link

Amazing!

@emgsilva
Copy link
Contributor

I like the coloring too, it makes things "jumps out" more into one's eyes.

Some little things I would propose to "refactor":

  • Define: keep the canvas (Bounded Context Canvas) sketch/icon, instead of the new graphics... or mix/merge them? I think it is good to show that sort of tool and focus we do there.
  • Code: try to still show the "Aggregate" diagram from the old diagram, which really shows an important aspect of that phase (and recommendation of using the Aggregate Design Canvas)
  • Organize: maybe you could add three "circles" (teams), looks like there is something missing on the top-left part of the image :D

Anyways, these are just small things (and maybe some are too literal and focused on the "tools" we use on each phase... but those popped out when I was looking at the colored diagram). I think in general color really highlights things in the diagram, good job @jlasoc1!

@javujavichi
Copy link
Collaborator Author

I like the coloring too, it makes things "jumps out" more into one's eyes.

Some little things I would propose to "refactor":

  • Define: keep the canvas (Bounded Context Canvas) sketch/icon, instead of the new graphics... or mix/merge them? I think it is good to show that sort of tool and focus we do there.
  • Code: try to still show the "Aggregate" diagram from the old diagram, which really shows an important aspect of that phase (and recommendation of using the Aggregate Design Canvas)
  • Organize: maybe you could add three "circles" (teams), looks like there is something missing on the top-left part of the image :D

Anyways, these are just small things (and maybe some are too literal and focused on the "tools" we use on each phase... but those popped out when I was looking at the colored diagram). I think in general color really highlights things in the diagram, good job @jlasoc1!

I'll look into this, thank you for the feedback, sorry the late reply I'm in Chile timezone hahaha :)

@javujavichi
Copy link
Collaborator Author

Hey folks, the PR was updated from the feedback comments of @emgsilva 😄
thanks for pointing out those details, I almost missed the circled with the people hahaha
I also modified the icons as requested, let me know if something else is needed if not, feel free to merge 🥳

@AlexZeitler
Copy link

Looks good to me - I like it! 👍

@Max-Git
Copy link
Member

Max-Git commented Jun 30, 2022

I love that colored picture! 🤩 Thanks again @jlasoc1 ! Do you think it would be possible to add the subtitle sentence that was on the previous version? I think it adds some useful context on how to use the process that avoid people being too dogmatic about it. Thanks!

@NTCoding
Copy link
Member

NTCoding commented Jun 30, 2022

Honestly, I think it's great. It's much better and more appealing with colour in my opinion. If there was 1 thing I would change it would be the arrows, maybe use a slightly lighter grey and a bit of opacity so you can see the arrows overlapping a bit.

Is it too soon to ask @jlasoc1 to give this repo a makeover as well 😅? https://github.com/ddd-crew/welcome-to-ddd

EDIT: there is some opacity and you can see the arrows are overlapping 😂 Me stupid.

@NTCoding NTCoding requested review from a team and NTCoding June 30, 2022 14:12
@NTCoding NTCoding requested a review from a team June 30, 2022 14:14
@NTCoding
Copy link
Member

@jlasoc1 feel free to merge this whenever you are ready and have finished reviewing the feedback. You should have permissions to do that.

@javujavichi
Copy link
Collaborator Author

Wooow @NTCoding that repo looks amazing for a makeover hahaha, I'll take a look. My design skills have limits hahahah

@javujavichi
Copy link
Collaborator Author

I'll merge the file @Max-Git if you want me to do any other change I can definitely post another PR, we can improve this as much as we want 🥳

@javujavichi javujavichi merged commit 018d0b5 into master Jun 30, 2022
@Max-Git
Copy link
Member

Max-Git commented Jul 1, 2022

Many thanks @jlasoc1 !!!

@mploed
Copy link
Contributor

mploed commented Jul 1, 2022

Thanks @jlasoc1 this looks amazing!

@yellowbrickc yellowbrickc deleted the new-image-modeling-process-arrows branch July 1, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants